Audit printenv(1)

1) argc style
2) safeguard argv-loop as already seen in echo(1) with argc-decrement.
This commit is contained in:
FRIGN
2015-02-28 21:47:17 +01:00
parent 6f715d8c6d
commit 0226c05105
3 changed files with 7 additions and 6 deletions

View File

@@ -9,7 +9,7 @@ extern char **environ;
static void
usage(void)
{
eprintf("usage: %s [variable...]\n", argv0);
eprintf("usage: %s [var ...]\n", argv0);
}
int
@@ -23,16 +23,17 @@ main(int argc, char *argv[])
usage();
} ARGEND;
if (argc == 0) {
if (!argc) {
while (*environ)
printf("%s\n", *environ++);
} else {
while (*argv) {
if ((var = getenv(*argv++)))
for (; argc > 0; argc--, argv++) {
if ((var = getenv(*argv)))
printf("%s\n", var);
else
ret = 1;
}
}
return ret;
}